<html>
<head><meta charset="utf-8"><title>crater triage 1.54 · t-release · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/index.html">t-release</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html">crater triage 1.54</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="244203961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244203961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244203961">(Jun 28 2021 at 21:00)</a>:</h4>
<p>beta run is done, rustdoc in next few days, <a href="https://github.com/rust-lang/rust/issues/86597#issuecomment-869839539">https://github.com/rust-lang/rust/issues/86597#issuecomment-869839539</a></p>
<p>Would someone be up for triaging the results?</p>



<a name="244203983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244203983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244203983">(Jun 28 2021 at 21:00)</a>:</h4>
<p>cc <span class="user-group-mention" data-user-group-id="2907">@T-release</span></p>



<a name="244633375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244633375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244633375">(Jul 01 2021 at 22:11)</a>:</h4>
<p>rustdoc is now also complete...</p>



<a name="244633547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244633547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244633547">(Jul 01 2021 at 22:13)</a>:</h4>
<p>don't really have the time to triage it :(</p>



<a name="244639670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244639670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244639670">(Jul 01 2021 at 23:25)</a>:</h4>
<p>this looks unrelated to rustdoc:</p>
<div class="codehilite"><pre><span></span><code>[INFO] [stdout] error[E0412]: cannot find type `NoneError` in module `std::option`
[INFO] [stdout]  --&gt; src/command_parser/run_command.rs:5:112
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn run(msg: &amp;serenity::model::channel::Message, ctx: &amp;serenity::client::Context) -&gt; Result&lt;(),std::option::NoneError&gt; {
[INFO] [stdout]   |                                                                                                                ^^^^^^^^^ not found in `std::option`
</code></pre></div>
<p><code>NoneError</code> is a nightly API that was removed for TryV2 AFAIK</p>



<a name="244639848"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244639848" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244639848">(Jul 01 2021 at 23:28)</a>:</h4>
<p>rustdoc runs are best to triage after the main run, most of the bugs detected there are the same ones as in rustc</p>



<a name="244639886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244639886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244639886">(Jul 01 2021 at 23:28)</a>:</h4>
<p>Ok. In that case I'll skip straight to my main point: the rustdoc crater runs will continue to be near-useless until <a href="https://github.com/rust-lang/crater/issues/532">https://github.com/rust-lang/crater/issues/532</a> is implemented.</p>



<a name="244639911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244639911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244639911">(Jul 01 2021 at 23:29)</a>:</h4>
<p>I have <a href="https://github.com/rust-lang/crater/pull/543">a PR</a> that's been open for about 6 months. I don't know how to make progress on it - I think it just needs review?</p>



<a name="244640537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244640537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244640537">(Jul 01 2021 at 23:36)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I know you're busy, but would you have time to look at that sometime in the next couple weeks?</p>



<a name="244664972"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244664972" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244664972">(Jul 02 2021 at 06:49)</a>:</h4>
<p>it's in the backlog for things to look at</p>



<a name="244822779"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244822779" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244822779">(Jul 03 2021 at 20:28)</a>:</h4>
<p>okay, these are all done as of last night</p>



<a name="244822786"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.54/near/244822786" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E54.html#244822786">(Jul 03 2021 at 20:29)</a>:</h4>
<p>nothing major turned up (yay!) - hopefully that holds for the rest of the cycle.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>